Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinear finite-volume schemes, constant pressure aquifers, converter for CO2STORE, simplify thermal #54

Merged
merged 43 commits into from
Aug 31, 2024

Conversation

moyner
Copy link
Member

@moyner moyner commented Aug 31, 2024

No description provided.

moyner and others added 30 commits August 6, 2024 10:17
* Add overloads for ntpfa

* Make it easier to use non-TPFA setups

* Add kgrad to setup_reservoir_model kwarg

* Update flux_nfvm.jl

* Improvements to NFVM support

* NFVM: Clean up flux code

* Fix sign for NFVM flux with gravity

* Pass on trans to NFVM code

* Improve logic for NFVM potential

* NFVM: Correct typo

* Hacked in diffusion support for NFVM

* Ensure that NFVM potential is always non-negative

We do this by picking a new reference depth

* Update porousmedia.jl

* Put in place some preparation for fvm asm

* Update discretization settings to account for new features

* Fix general_ad branch in tpfv domain

* Hack for NLDD without TPFA hard coded (won't work for ASPEN)

* Handle new discretizations in thermal
* Refactor thermal to not use composite system

* Remove export of undefined system

* Don't add rock parameters for wells

* Update thermal test

* Clean up thermal tests

* input file: Use simpler thermal system

* Thermal: Apply perforation mask to perforation flow
@moyner moyner merged commit e718be0 into main Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants